carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Maximo Asset Monitor (Watson IoT), IBM Maximo Visual Inspection, and Graphite products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

feat(barchartcard): add maximum data points field #3753

Closed erzhan-temir-mamyrov closed 1 year ago

erzhan-temir-mamyrov commented 1 year ago

Closes #3663

Summary

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

netlify[bot] commented 1 year ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit 727c6d0dea5d74b5c6f56f0ea31cb4da472b29a3
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/643d9bf8e2d0af000862934d
Deploy Preview https://deploy-preview-3753--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

erzhan-temir-mamyrov commented 1 year ago

@jessieyan I've checked the content of JSON configuration and it depends on cardConfig prop. For example, I tried to add maximumDataPoints to card config prop in this story, then its field in displayed in JSON editor.

jessieyan commented 1 year ago

@herleraja Hello Amritha, would you please also have a review?