carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Maximo Asset Monitor (Watson IoT), IBM Maximo Visual Inspection, and Graphite products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

feat(table): add custom input to header columns #3767

Open EKong-IBM opened 1 year ago

EKong-IBM commented 1 year ago

GRAPHITE-58370

Summary

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

Things to look for during review

netlify[bot] commented 1 year ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit 0d6c89fda24cb011bd45cdf2d314730ba2f6a3f2
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6446cd273079e80008b2b0b5
Deploy Preview https://deploy-preview-3767--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

EKong-IBM commented 1 year ago

I wasn't quite able to resolve the unit test issues, but I had followed David's review and the display seemed to work properly.

packages/react/src/components/Table/TableHead/TableHead.jsx customInput: column?.customInput, -> customInput: column.filter?.customInput,

packages/react/src/components/Table/Table.story.helpers.jsx customInput: <div>customInput</div>, -> filter: { customInput: <div>customInput</div> },

erzhan-temir-mamyrov commented 1 year ago

@sls-ca I am not sure. I can follow up with Graphite ticket and resolve merge conflicts.

JordanWSmith15 commented 1 year ago

@sls-ca it is needed still, it just isn't high priority any more. Let's let it sit for a while, and some other dev will pick it up and finish it.