carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Maximo Asset Monitor (Watson IoT), IBM Maximo Visual Inspection, and Graphite products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

[DateTimePickerV2]: show error message when date is not select ( single select) #3777

Closed jessieyan closed 1 year ago

jessieyan commented 1 year ago

Closes #3691

Summary

The changes are only for DateTimePickerV2 single select cause we do not want to change behaviors for old DateTimePickerV2 and only single select has the clear button which would cause date is not selected.

A few changes here:

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

https://user-images.githubusercontent.com/24279794/234600918-524c84c2-9a85-43f6-840d-fc9b19d7e6b6.mov

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

jessieyan commented 1 year ago

I need to add some more tests.

netlify[bot] commented 1 year ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit 4b95c0d236772b2182ff7a61453341aabc03bad5
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/64484ea35bfa06000865e347
Deploy Preview https://deploy-preview-3777--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.