Closed jessieyan closed 1 year ago
I need to add some more tests.
Name | Link |
---|---|
Latest commit | 4b95c0d236772b2182ff7a61453341aabc03bad5 |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/64484ea35bfa06000865e347 |
Deploy Preview | https://deploy-preview-3777--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Closes #3691
Summary
The changes are only for
DateTimePickerV2
single select cause we do not want to change behaviors for oldDateTimePickerV2
and onlysingle select
has theclear
button which would cause date is not selected.A few changes here:
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)
https://user-images.githubusercontent.com/24279794/234600918-524c84c2-9a85-43f6-840d-fc9b19d7e6b6.mov
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.