Closed kalyanixraut closed 1 year ago
Name | Link |
---|---|
Latest commit | dd1fc61805b7a5061a4697306b9e8a1c6368d884 |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/649564e892160200082b7e18 |
Deploy Preview | https://deploy-preview-3807--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Closes #GRAPHITE-64846
Summary
TabListTemplate
component in Graphite storybook following violations were found and this PR is to fix those accessibility scan violations.Change List (commits, features, bugs, etc)
role='menuitem'
from HeaderActions which is used in<button />
and causing violations in a11y scans.Acceptance Test (how to verify the PR)
Header
andSuitHeader
should work as before.Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.