carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Watson IoT products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 77 forks source link

fix(IdleTimer): Preventing the IdleTimer logic to start its timer if timeout is 0. #3825

Closed blechner closed 1 year ago

blechner commented 1 year ago

Preventing the IdleTimer logic to start its timer if timeout is 0. This is generally not needed as IdleLogoutConfirmationModal does a 0 check before instantiating IdleTimer.js, however, for apps consuming IdleTimer directly, it doesn't hurt to add an extra check to avoid errors.

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

netlify[bot] commented 1 year ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit a2e5c2bf4430a17526f29a064b7d680d9f62004a
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/64ff4c6e12fefd0008f772e1
Deploy Preview https://deploy-preview-3825--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.