Closed hectordavis closed 1 year ago
Name | Link |
---|---|
Latest commit | f5f69b411cfc9b1580f534ca295136a57fa05c2f |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6511aaa53aa35600084ebe86 |
Deploy Preview | https://deploy-preview-3826--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Closes https://jsw.ibm.com/browse/GRAPHITE-67441
Summary
Change List (commits, features, bugs, etc)
closeSideNavOnNavigation
prop added to SuiteHeader to enable side nav to close when clicking one of its items.isActive
prop passed from Header to HeaderMenuButton in order to show the Close menu iconAcceptance Test (how to verify the PR)
Close side nav on navigation
knob then open the side nav again by clicking the hamburger menu, then click "Home" and check if the side nav closes. Repeat the same but now for Dashboard > Link 1 item and check if the side nav closes after clicking.Regression Test (how to make sure this PR doesn't break old functionality)
Close side nav on navigation
knob and check if the side nav remains open after clicking the itemsThings to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.