carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Maximo Asset Monitor (Watson IoT), IBM Maximo Visual Inspection, and Graphite products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

feat: close header side nav on navigation #3826

Closed hectordavis closed 1 year ago

hectordavis commented 1 year ago

Closes https://jsw.ibm.com/browse/GRAPHITE-67441

Summary

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

  1. Go to SuiteHeader > Legacy (single workspace only) > Header with side nav story and click the hamburger icon to check if the Close icon is displayed. Then click the close icon to see if it changes back to hamburger menu.
  2. In the same story, check the Close side nav on navigation knob then open the side nav again by clicking the hamburger menu, then click "Home" and check if the side nav closes. Repeat the same but now for Dashboard > Link 1 item and check if the side nav closes after clicking.

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

netlify[bot] commented 1 year ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit f5f69b411cfc9b1580f534ca295136a57fa05c2f
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6511aaa53aa35600084ebe86
Deploy Preview https://deploy-preview-3826--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.