Closed cgirani closed 1 year ago
Name | Link |
---|---|
Latest commit | 29fd7e8af116eff8bf44b43a2ce027ac34b09ad4 |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6530228b6a9eb800084255bc |
Deploy Preview | https://deploy-preview-3830--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
can you check if this effect dashboard code editor example : https://deploy-preview-3830--carbon-addons-iot-react.netlify.app/?path=/story/2-watson-iot-experimental-%E2%98%A2%EF%B8%8F-dashboardeditor--with-editable-title
Summary
New component CodeEditor
Change List (commits, features, bugs, etc)
@monaco-editor/react
packageAcceptance Test (how to verify the PR)
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.