carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Maximo Asset Monitor (Watson IoT), IBM Maximo Visual Inspection, and Graphite products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

feat: removed additional condition for current node #3841

Closed Happyrajsinh closed 9 months ago

Happyrajsinh commented 9 months ago

Class validation is enough as Graphite have custom implementation of breadcrumb which style span element as hyperlink hence this change is needed to allow that kind of drop targets as well.

Closes #3840

Summary

Graphite shows even active breadcrumb nodes as span elements instead of hyperlink hence removing the extra check.

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

netlify[bot] commented 9 months ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit 67eef98cc6ea0dcbe0c966829518cf6034d43de8
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/65c1e07a51235f0008f2a20d
Deploy Preview https://deploy-preview-3841--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.