Fix empty table colspan single select

aqibibm commented 9 months ago

Summary

For single Selection, Empty Table colspan was calculated one less column which was causing white space at the end.

Change List (commits, features, bugs, etc)

Added Single Selection condition along with Multi selection in Table.js for totalColumns

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

[ ] Make sure all references to iot or bx class prefix is using the prefix variable
[ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
[ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
[ ] All strings should be translatable.
[ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
[ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
[ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
[ ] Changes or new components should either write new or update existing documentation.
[ ] PR should link and close out an existing issue

netlify[bot] commented 9 months ago

Name	Link
Latest commit	416e3be738364924f01fe02634c16a3b70fa491a
Latest deploy log	https://app.netlify.com/sites/carbon-addons-iot-react/deploys/65d5a5bc7e9e3f000872bf6f
Deploy Preview	https://deploy-preview-3843--carbon-addons-iot-react.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cgirani commented 9 months ago

@aqibibm can you add a screenshot, or point what storybook I could validate it?

herleraja commented 8 months ago

can you please create an issue in this repo and attach it to the PR to check the issue details

aqibibm commented 8 months ago

@aqibibm can you add a screenshot, or point what storybook I could validate it?

In this, use Selection mode "Single" and search anything random for "NO Data" message.

aqibibm commented 8 months ago

can you please create an issue in this repo and attach it to the PR to check the issue details

carbon-design-system / carbon-addons-iot-react