Open kristy-tabak opened 6 months ago
Name | Link |
---|---|
Latest commit | a9123084dea3a0e83c1d49f93e70b1f33e6235c2 |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/66458ceab9bfd00008eb6a1e |
Deploy Preview | https://deploy-preview-3864--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Closes # [Accessiblity] Issue in the component from outdated library #62074
Summary
Licensing Development Project consuming SuiteHeader component from carbon-addons-iot-react library, "SuiteHeader" component has accessibility issue related to the requirement: "Provide accessibility properties".
The type attribute is specifying the context of usage and it is a good practice to always declare the type of a button explicitly.
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.