carbon-design-system / carbon-addons-iot-react

A collection of React components shared between IBM Maximo Asset Monitor (Watson IoT), IBM Maximo Visual Inspection, and Graphite products.
https://carbon-design-system.github.io/carbon-addons-iot-react/
Apache License 2.0
96 stars 78 forks source link

fix(suiteheader): added the type attribute to the btn #3864

Open kristy-tabak opened 6 months ago

kristy-tabak commented 6 months ago

Closes # [Accessiblity] Issue in the component from outdated library #62074

Summary

Licensing Development Project consuming SuiteHeader component from carbon-addons-iot-react library, "SuiteHeader" component has accessibility issue related to the requirement: "Provide accessibility properties".

The type attribute is specifying the context of usage and it is a good practice to always declare the type of a button explicitly.

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

Regression Test (how to make sure this PR doesn't break old functionality)

Things to look for during review

netlify[bot] commented 6 months ago

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit a9123084dea3a0e83c1d49f93e70b1f33e6235c2
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/66458ceab9bfd00008eb6a1e
Deploy Preview https://deploy-preview-3864--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.