search

carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:⠀Robust dataviz framework implemented using D3 & typescript
https://charts.carbondesignsystem.com
Apache License 2.0
904 stars 183 forks source link

[Bug]: peer dependency warnings with charts-react #1201

Open Fryguy opened 2 years ago

Fryguy commented 2 years ago

Contact Details

jason.frey@ibm.com

What happened?

When using carbon charts-react via yarn, we get peer dependency warnings. These should probably be fixed in upstream carbon/charts-react. The output of yarn explain peer-requirements is below.

➤ YN0000: @carbon/charts-react@npm:0.41.103 [5c616] doesn't provide d3, breaking the following requirements:

➤ YN0000: @carbon/charts@npm:0.41.103 [5c616] → 7.x ✘

I think the fix is to add d3 7.x into the package.json as a peer dependency, or if it's an optional dependency, then as an optional dependency. I'm not exactly sure on the right versions though, so I figured you were in a better position to fix.

Version

@carbon/charts@npm:0.41.103 @carbon/charts-react@npm:0.41.103

Data & options used

No response

Relevant log output

No response

Codesandbox example

No response

nstuyvesant commented 1 year ago

Hi @Fryguy - are you seeing this issue in @carbon/charts-react@1.11.8? If not, can you please close this issue?