carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:β €Robust dataviz framework implemented using D3 & typescript
https://charts.carbondesignsystem.com
Apache License 2.0
913 stars 185 forks source link

fix(react): remove react-jsx-runtime from bundles #1799

Closed theiliad closed 6 months ago

theiliad commented 6 months ago

react-jsx-runtime logic was showing up in our react bundles, this should remove it

netlify[bot] commented 6 months ago

Deploy Preview for carbon-charts-react ready!

Name Link
Latest commit c064ed2f7f2af1cdf94ffc04bb3ea0492104c611
Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/6631061cd6aa6d0008418468
Deploy Preview https://deploy-preview-1799--carbon-charts-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for carbon-charts-core ready!

Name Link
Latest commit c064ed2f7f2af1cdf94ffc04bb3ea0492104c611
Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/6631061c1d642c00081e4db1
Deploy Preview https://deploy-preview-1799--carbon-charts-core.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Deploy Preview for carbon-charts-angular ready!

Name Link
Latest commit c064ed2f7f2af1cdf94ffc04bb3ea0492104c611
Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/6631061ce831fc0008d205b6
Deploy Preview https://deploy-preview-1799--carbon-charts-angular.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

theiliad commented 6 months ago

Nvm, seems like it's good practice to keep it in there