search

carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:⠀Robust dataviz framework implemented using D3 & typescript
https://charts.carbondesignsystem.com
Apache License 2.0
876 stars 182 forks source link

Does `@carbon/charts-react` support React 17? #1841

Closed s100 closed 2 weeks ago

s100 commented 3 weeks ago

We use @carbon/charts-react@1.16.3 and we also use React 17 at present. In the package.json for @carbon/charts-react, we see:

https://github.com/carbon-design-system/carbon-charts/blob/ca97715d352a589fb69e788174fac7313f8b2426/packages/react/package.json#L48-L53

In the production dependencies, React 18 appears to be the minimum required version. This is causing us peer dependency issues and we are having to specify an override in our package.json to get a successful npm install. But in the peer dependencies, it seems as if React 16, 17 and 18 are all acceptable. I'm not certain why react and react-dom are listed as both production and peer dependencies or why the version ranges disagree with one another. I'd recommend eliminating the peer dependencies entirely. And, if CCR supports React 16 and 17, could you please update the production dependencies to reflect this?

s100 commented 2 weeks ago

Following #1849, we now see that @carbon/charts-react@1.16.9 has no React dependencies, only peerDependencies on React 16, 17 or 18. Thank you.