carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:β €Robust dataviz framework implemented using D3 & typescript
https://charts.carbondesignsystem.com
Apache License 2.0
876 stars 182 forks source link

fix(all packages): missing options, package.json and lint fixes #1849

Closed nstuyvesant closed 2 weeks ago

nstuyvesant commented 2 weeks ago

Updates

  1. Added StackedBarChartOptions to exports for all packages. Closes https://github.com/carbon-design-system/carbon-charts/issues/1845
  2. For @carbon/charts-react move react and react-dom to devDependencies and make peerDependencies to match @carbon/react. Closes https://github.com/carbon-design-system/carbon-charts/issues/1841
  3. Similar to item 2 but for Vue (proactive).
  4. Minor lint changes to remove errors related to demos (missing props, prop types, const vs. let).
  5. More JSDoc comments.
  6. Drop D3 as a peerDependency for core as it's inadvertently been getting bundled all along (total JavaScript bundle size is 206.3K gzipped). The size has come down quite a bit due to more efficient imports implemented back in 1.9.x. Benefit: setup process is simpler and the size trade-off is minimal (and again, was already in the bundle).
netlify[bot] commented 2 weeks ago

Deploy Preview for carbon-charts-core ready!

Name Link
Latest commit 2f1630588349d8d5952e55b96fe86c9f2317cfa9
Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/666da867e0c43a0008b46a7b
Deploy Preview https://deploy-preview-1849--carbon-charts-core.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for carbon-charts-angular ready!

Name Link
Latest commit 2f1630588349d8d5952e55b96fe86c9f2317cfa9
Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/666da867567c7b000861145e
Deploy Preview https://deploy-preview-1849--carbon-charts-angular.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for carbon-charts-react ready!

Name Link
Latest commit 2f1630588349d8d5952e55b96fe86c9f2317cfa9
Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/666da8671c19dd00080e55b5
Deploy Preview https://deploy-preview-1849--carbon-charts-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.