search

carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:⠀Robust dataviz framework implemented using D3 & typescript
https://charts.carbondesignsystem.com
Apache License 2.0
904 stars 184 forks source link

[Bug]: Redefined variables violating no-shadow rule #1850

Closed nstuyvesant closed 3 months ago

nstuyvesant commented 3 months ago

Relevant package(s)

Carbon Charts Version

1.16.7

Which bundler are you using?

Vite

What happened and what did you expect to happen?

Eslint identified 4 bugs in core:

  1. packages/core/src/selectedGroups.spec.ts - prefix is imported but then redefined
  2. packages/core/src/components/graphs/gauge.ts - value const defined on line 170 then redefined in arrow function on line 214
  3. packages/core/src/components/graphs/heatmap.ts - domainIdentifier const defined on line 58 then redefined in arrow function on 116
  4. packages/core/src/components/graphs/radar.ts - const data defined on line 54 and arrow function parameter of same name defined on line 97

Chart data and options (automatically formatted so no need for backticks)

N/A

JavaScript console or build output (if relevant)

N/A

StackBlitz repro

No response

IBM Application/Team (if relevant)

No response

What priority level would this be in your opinion?

P1 (High)