fix(1856): add cjs to umd bundles and update package.json exports

carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:⠀Robust dataviz framework implemented using D3 & typescript

https://charts.carbondesignsystem.com

Apache License 2.0

876 stars 182 forks source link

Closed nstuyvesant closed 2 weeks ago

nstuyvesant commented 2 weeks ago

Vite.js recommends that library projects have "type": "module" in their package.json. If you are generating UMD, Vite now defaults to adding a .cjs extension to reinforce that it should be loaded with require.
@carbon/charts and @carbon/charts-react generate UMD files but their extensions where .js. Because their package.json files had "type": "module", Webpack assumed these to be ES modules - not UMD.
This change makes the UMD bundles for both packages end in .cjs so Webpack recognizes their format correctly.
Should close https://github.com/carbon-design-system/carbon-charts/issues/1856 but needs to be confirmed

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	7052c9661a514e86e8de089cb88d7dfdc342ad6f
Latest deploy log	https://app.netlify.com/sites/carbon-charts-core/deploys/66709cd8d386b7000824c43f
Deploy Preview	https://deploy-preview-1857--carbon-charts-core.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	7052c9661a514e86e8de089cb88d7dfdc342ad6f
Latest deploy log	https://app.netlify.com/sites/carbon-charts-angular/deploys/66709cd8138842000878b29b
Deploy Preview	https://deploy-preview-1857--carbon-charts-angular.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Name	Link
Latest commit	7052c9661a514e86e8de089cb88d7dfdc342ad6f
Latest deploy log	https://app.netlify.com/sites/carbon-charts-react/deploys/66709cd8585dec00080ad8e9
Deploy Preview	https://deploy-preview-1857--carbon-charts-react.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.