carbon-design-system / carbon-charts

:bar_chart: :chart_with_upwards_trend:⠀Robust dataviz framework implemented using D3 & typescript
https://charts.carbondesignsystem.com
Apache License 2.0
905 stars 184 forks source link

Displaying Gaps in a time-series line chart #280

Closed kennethdnguyen closed 4 years ago

kennethdnguyen commented 5 years ago

I am submitting a...

charts version:

v10

Issue description

We are trying to display time-series data in a line chart, and it’s possible that we won’t have data for every point in time for a given dataset. Right now, the chart just handles null values as 0 and connects the dots, but we would like to have those gaps displayed visually as gaps instead.

Steps to produce the issue

Change one of the values of data to have a null value, and then the line chart will continue to connect the dots using the value 0.

Current behavior

Screen Shot 2019-06-17 at 2 24 57 PM

Expected behavior

Screen Shot 2019-06-17 at 10 46 52 AM
theiliad commented 5 years ago

Thanks @kennethdnguyen.

theiliad commented 5 years ago

I played around with this locally, is this what you're hoping to achieve? image

image

kennethdnguyen commented 5 years ago

@theiliad Sorry for the very late response. To answer your questions, yes we want to do it in a time series graph.

The latest screenshot you have attached is definitely what we want to achieve yes. It looks great. Thank you for attaching the screenshot of what you have worked on locally!

Another tool we used in the past to display the data was Kibana. This is what it looks like with the gap in the data. kiban

theiliad commented 4 years ago

This has been addressed in #299, and will be implemented in Q1

theiliad commented 4 years ago

Closed by #464