carbon-design-system / carbon-components-angular

An Angular implementation of the Carbon Design System for IBM.
https://angular.carbondesignsystem.com
Apache License 2.0
533 stars 307 forks source link

Text input implementation lacks feature parity with React version #2291

Open miqh opened 2 years ago

miqh commented 2 years ago

Detailed description

The Angular text input implementation lacks feature parity with the equivalent React version for Carbon Design System v10.

Specifically,

Steps to reproduce the issue

Visit:

In the React version, make use of the "Inline variant (inline)" and "Readonly variant (readOnly)" knobs. None of the stories offer the ability to change the placeholder text, but it's implemented in React.

Additional information

React text input read-only: image React text input inline label: image

anemonetea commented 1 year ago

I have created a PR that implements the read-only and inline inputs, but not sure what was meant by the last point -- "No ability to change placeholder text". Carbon-ng allows to change the placeholder text and this is in Storybook.

For textarea, is it not meant to have read-only state? The CSS from carbon-design-system doesn't quite work for it... but it's another input type that can be used with the ibm-label component in carbon-ng.