search

carbon-design-system / carbon-components-angular

An Angular implementation of the Carbon Design System for IBM.
https://angular.carbondesignsystem.com
Apache License 2.0
535 stars 308 forks source link

Add fluid state for Date picker #2886

Open Akshat55 opened 6 months ago

Akshat55 commented 6 months ago

Ref: https://github.com/carbon-design-system/carbon-components-angular/issues/2769

coreset commented 1 month ago

@Akshat55 I wanted to check in to see if this issue is still open for fixes. Please let me know if there's anything I can do to help.

Akshat55 commented 1 month ago

@coreset Doesn't seem to be the case, would you like me to be assigned to it?

coreset commented 1 month ago

HI @Akshat55 Yes, please go ahead and assign me to the issue. I’d be happy to start working on it. Looking forward to contributing!

eduardmarcinco commented 1 month ago

Hello, I actually tried to implement fluid state for date picker couple week ago but hit a wall due to bloated DOM structure that is described in #2822 It looks like PR #2823 needs to be merged before fluid state can be implemented.

Just my 2 cents. Maybe you'll find a way to implement it.

coreset commented 1 month ago

Hello, I actually tried to implement fluid state for date picker couple week ago but hit a wall due to bloated DOM structure that is described in #2822 It looks like PR #2823 needs to be merged before fluid state can be implemented.

Just my 2 cents. Maybe you'll find a way to implement it.

@eduardmarcinco thank you for sharing your insights! I appreciate the context regarding the challenges you faced with the fluid state for the date picker. I'll take a closer look at PR #2823 and see how it can help in moving forward with this implementation. Your input is valuable, and I'll keep you posted on any progress or discoveries I make. My goal is fix this without breaking changes.