carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System
https://svelte.carbondesignsystem.com
Apache License 2.0
2.71k stars 261 forks source link

Prepare package for v1 + Svelte 5 readiness #1877

Open theetrain opened 10 months ago

theetrain commented 10 months ago

Before publishing v1 package:

theetrain commented 6 months ago

I tried installing and testing svelte@5.0.0-next.115.

Test branch: https://github.com/carbon-design-system/carbon-components-svelte/tree/chore/svelte-5-test Changes made: https://github.com/carbon-design-system/carbon-components-svelte/commit/bd3ea6dbf171405fc20814ab1aa224e2d59f89e9

I ran the docs: cd docs && yarn dev, but then ran into this runtime error:

Uncaught TypeError: Cannot read properties of undefined (reading 'call')

Which points to this presumably svelte-generated code:

function clone_node(node, deep) {
  return (
    /** @type {N} */
    clone_node_method.call(node, deep)
//  ^ this is `undefined`
  );
}

Going to try coming back to this later and find out why this happens.