carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System
https://svelte.carbondesignsystem.com
Apache License 2.0
2.68k stars 261 forks source link

TextInput v11 Styles #1889

Closed SimpleProgrammingAU closed 8 months ago

SimpleProgrammingAU commented 8 months ago

Tasks completed and ready for review

Tasks outstanding

I also alphabetised the prop list for legibility. I figured this was a good point to submit a PR since all v11 style stuff is done, just need to tidy up the loose ends with the other bugs.

brunnerh commented 8 months ago

I would recommend doing things that cause a lot of non-functional differences, like sorting properties, in separate PRs. That makes it easier to review as there is less noise.

theetrain commented 8 months ago

@brunnerh that's a good tip; I moved this outcome to its own ticket: #1891.

I'll try reviewing this PR as-is for now.

SimpleProgrammingAU commented 8 months ago

I would recommend doing things that cause a lot of non-functional differences, like sorting properties, in separate PRs. That makes it easier to review as there is less noise.

I thought the same thing after the fact. I sorted the properties because I was having so much difficulty finding them in the code as I was reviewing against the React component.

theetrain commented 8 months ago

Sorry I submitted my review prematurely. I was using VSCode to review and didn't realize 'request changes' would immediately submit. I'll follow up with the remainder of my review.

image
SimpleProgrammingAU commented 8 months ago

Thanks for the feedback. Back to you :)