Closed SimpleProgrammingAU closed 8 months ago
I would recommend doing things that cause a lot of non-functional differences, like sorting properties, in separate PRs. That makes it easier to review as there is less noise.
@brunnerh that's a good tip; I moved this outcome to its own ticket: #1891.
I'll try reviewing this PR as-is for now.
I would recommend doing things that cause a lot of non-functional differences, like sorting properties, in separate PRs. That makes it easier to review as there is less noise.
I thought the same thing after the fact. I sorted the properties because I was having so much difficulty finding them in the code as I was reviewing against the React component.
Sorry I submitted my review prematurely. I was using VSCode to review and didn't realize 'request changes' would immediately submit. I'll follow up with the remainder of my review.
Thanks for the feedback. Back to you :)
Tasks completed and ready for review
TextInput
andTextInputSkeleton
(#1888)FluidForm
issues relating toTextInput
(#1667)slot
s forhelperText
(#1633),invalidText
,warnText
(#1621)elementAttribute
objects to replace$$restProps
(#1621) - isRecord<string, string>
the correct type for these?Tasks outstanding
752: I think this issue might be better resolved in
Select
- up for discussion941: I couldn't open the REPL links without errors to see the issue
545: I haven't tried to tackle this one yet, will try to address it when I look at the other outstanding tasks above
I also alphabetised the prop list for legibility. I figured this was a good point to submit a PR since all v11 style stuff is done, just need to tidy up the loose ends with the other bugs.