Layer (new component) - Githubissues

carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System

https://svelte.carbondesignsystem.com

Apache License 2.0

2.71k stars 261 forks source link

Layer (new component) #1892

Open theetrain opened 9 months ago

theetrain commented 9 months ago

Spun off from #1629

[ ] Add new Layer component. Reference: https://react.carbondesignsystem.com/?path=/docs/components-layer--overview
[ ] Deprecate the light prop from TextInput. Recommend using Layer component instead. To be removed in carbon-components-svelte@2.0.0.
[ ] Adjust related components to ensure they work well with Layer

SimpleProgrammingAU commented 9 months ago

I don't think the light prop should be removed in v11. The React library has it marked for removal in v12, doesn't it?

theetrain commented 9 months ago

You're right that the React component has it deprecated; probably to ease into its removal when Layer became available, but not because of forthcoming v12 styles. We should follow a similar backwards-compatibility cadence:

https://github.com/carbon-design-system/carbon/blob/be888a850730d9658decaf1336f4b3175eb4d817/packages/react/src/components/TextInput/TextInput.tsx#L84-L90

I updated the criteria above.

SimpleProgrammingAU commented 7 months ago

What are the outstanding tasks following the merge of PR #1932?