feat!: button v11 - Githubissues

carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System

https://svelte.carbondesignsystem.com

Apache License 2.0

2.68k stars 261 forks source link

feat!: button v11 #1895

Open theetrain opened 8 months ago

theetrain commented 8 months ago

Relates: #1641
For #1629

Meta

Todo

[x] Implement ButtonSet
[x] Implement ButtonSkeleton

Out of scope

[ ] Test with tooltip/popover, make appropriate changes; may have to work on #1896 and then patch Button
[ ] Implement Popover #1896

Button changes

BREAKING CHANGES

size prop has new values: sm, md, lg, xl, and 2xl. xl is the default.
kind prop has new values: danger-tertiary is now danger--tertiary (two hyphens), and danger-ghost is now danger--ghost (two hyphens)

Features

New 2xl size
expressive styles now apply to all button sizes

Fixes

Exports all SCSS styles using official conventions
All theme tokens are included in built CSS files

theetrain commented 8 months ago

I'm accepting preliminary reviews until the tasks above are complete.