carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System
https://svelte.carbondesignsystem.com
Apache License 2.0
2.68k stars 261 forks source link

Draft commit for review for Popover v11 #1896 #1930

Open SimpleProgrammingAU opened 6 months ago

SimpleProgrammingAU commented 6 months ago

I spent a couple hours adopting the CDS React approach to the Popover element and it appears to break the previously working approach in CDS Svelte (i.e. without providing a PopoverContent component).

Please have a quick look at what I've done and let me know if we should lean into what looks like a very breaking change or have I missed something that would allow the existing syntax, as shown in the current CDS Svelte documentation, to work?

Implemented:

Not yet implemented: