search

carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System
https://svelte.carbondesignsystem.com
Apache License 2.0
2.71k stars 261 forks source link

chore(ibm-common): add mandatory IBM instrumentation tags #1983

Closed jeffchew closed 3 months ago

jeffchew commented 4 months ago

Adding mandatory IBM intrumentation tags for Carbon Svelte.

jeffchew commented 4 months ago

@metonym fyi, this tag and footer needs to be added due to a recent IBM OPRT audit. This needs to be live by mid-August.

jeffchew commented 4 months ago

Appreciate the heads up – reviewed.

Thank you @metonym , I made an adjustment to hug the footer a bit more.

jeffchew commented 4 months ago

The sidenav is fixed position and I think it probably won't be able to fill the viewport height without a layout rewrite which is what I was trying to avoid.

metonym commented 4 months ago

Gotcha – I'll take a closer look at this.

jeffchew commented 3 months ago

@metonym wondering if we can merge this for now? We need to complete the compliance remediation by the 15th.

metonym commented 3 months ago

Moved to #1988

I built upon this PR so that the footer does not obstruct the side nav.

Screenshot 2024-08-07 at 8 07 42 AM
jeffchew commented 3 months ago

Moved to #1988

I built upon this PR so that the footer does not obstruct the side nav.

Thank you so much @metonym !