carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System
https://svelte.carbondesignsystem.com
Apache License 2.0
2.68k stars 261 forks source link

fix(header-action): allow vertical scroll when expanded #1992

Closed metonym closed 1 month ago

metonym commented 1 month ago

This PR hotfixes a usability issue: if the HeaderAction has vertical overflow, the overflow: hidden rule is not overridden.

This should ideally be fixed upstream:

In the meantime, however, the fix for Carbon Svelte ensures that the content is vertically scrollable (if necessary) to avoid requiring user intervention. This change can be reverted if and when this style is fixed in the upstream carbon-components library.

Otherwise, the consumer would need the following CSS:

:global(.bx--header-panel--expanded) {
  overflow-y: auto;
}

Screenshot 2024-08-13 at 9 27 13 AM
metonym commented 1 month ago

Fixed in v0.85.2