carbon-design-system / carbon-components-svelte

Svelte implementation of the Carbon Design System
https://svelte.carbondesignsystem.com
Apache License 2.0
2.71k stars 261 forks source link

Component audit #344

Open metonym opened 4 years ago

metonym commented 4 years ago

An extensive component audit must be performed before entertaining a v1 release.

Identify non-reactive props

Identify inconsistent or confusing prop/value nomenclature

Identify inconsistent use of dispatched events

Identify feature delta compared to flagship Carbon Design System

The basic expectation is that components from the library are compatible with the latest CSS from carbon-components.

What features are missing compared to their counterparts in the flagship Carbon library?

Identify components with insufficient or incomplete documentation

Refactor components w/ major breaking changes


Misc

Composed components should support dynamic create/update behavior

orta commented 4 years ago

I'd recommend also taking a look at the breakpoints for the UIShell when you have both a sidebar and navigation items, as at larger width it shows both

orta commented 4 years ago

( not trying to pile on, and I'm finding work-arounds by using the DOM API - so it's not a blocker for me, but better to report I assume )

Spotted this also Dropdown selectedIndex also is not reactive. Same with ContentSwitcher.

metonym commented 4 years ago

@orta I'll open separate issues for those

ispyinternet commented 4 years ago

Should Toggle and ToggleSmall be a configurable Toggle ?

metonym commented 4 years ago

@ispyinternet I agree. Besides the size, Toggle and ToggleSmall are pretty much identical. Related https://github.com/carbon-design-system/carbon/issues/6653