carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
609 stars 179 forks source link

CvPagination arrow icons are black on dark mode when active #1113

Closed thehowl closed 2 weeks ago

thehowl commented 3 years ago
    "@carbon/icons-vue": "^10.25.0",
    "@carbon/themes": "^10.16.0",
    "@carbon/vue": "^2.37.1",

As well as on the demo website here: http://vue.carbondesignsystem.com/?path=/story/components-cvpagination--default

Setting the theme to one of the dark themes makes the arrow black by default. On analysis, this seems to be caused by the fact the icon has the parameter fill="currentColor", which because the button text is of that dark grey color, causes the button to be that color as well.

image

Tested on:

Chromium 88.0.4324.150
Mozilla Firefox 85.0.1

Vue version should be 2.6.12.

Temporary workaround:

.bx--pagination__button:not(:disabled) > .bx--pagination__button-icon {
  fill: rgb(244, 244, 244);
  color: rgb(244, 244, 244);
}
github-actions[bot] commented 4 months ago

This issue has been marked as stale because it has required additional info or a response from the author for over 14 days. When you get the chance, please comment with the additional info requested. Otherwise, this issue will be closed in 14 days.

github-actions[bot] commented 1 month ago

This issue has been marked as stale because it has required additional info or a response from the author for over 14 days. When you get the chance, please comment with the additional info requested. Otherwise, this issue will be closed in 28 days.

github-actions[bot] commented 2 weeks ago

This issue has been closed because it has received no activity for 28 days.