feat: add slot to gain control over tabs switching buttons

carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System

http://vue.carbondesignsystem.com

Apache License 2.0

598 stars 177 forks source link

feat: add slot to gain control over tabs switching buttons #1523

Closed OlkaB closed 9 months ago

OlkaB commented 10 months ago

Contributes to #1522

What did you do?

Added slot to customise tab switching buttons' content

How have you tested it?

added test for slot in CvTabs.spec.js

Were docs updated if needed?

[x] Yes

sample:

davidnixon commented 10 months ago

I like this solution but I think using the label is a problem. The Label would often be localized so the "House" label might become "Taigh" or "Maison" or "Casa". Could you use the id instead?

OlkaB commented 10 months ago

fair point - change applied

OlkaB commented 9 months ago

oh gosh - truly. Done, thanks @davidnixon