search

carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
608 stars 180 forks source link

Improve inline notification story #1565

Open davidnixon opened 10 months ago

davidnixon commented 10 months ago

Title line template: [Improve inline notification story]: Add migration notes and slots examples

Detailed description

Inline Notification story docs should add migration notes similiar to inline loading to call out the removal of the v-html support for the subtitle.

https://vue.carbondesignsystem.com/?path=/story/component-cvinlinenotification--info

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Additional information

This displayed correctly in Vue2 components image

Example of updated usage: In Vue 2

      <cv-inline-notification
        style="margin: 0"
        kind="warning"
        title="Warning"
        :sub-title="getLink"
        :low-contrast="true"
        :hide-close-button="true"
      />

Where "getLink" returned an HTML string

In Vue 3

      <cv-inline-notification
        style="margin: 0"
        kind="warning"
        title="Warning"
        :low-contrast="true"
        :hide-close-button="true"
      >
        <template #sub-title>
          Requires you to submit a request for use.<br />
          <a target="_blank" :href="item.request_link">Link to request form</a>
        </template>
      </cv-inline-notification>
LucasGazetta commented 10 months ago

Hey, can i give it a look?

davidnixon commented 10 months ago

That would be great! Thanks!

github-actions[bot] commented 5 months ago

This issue has been marked as stale because it has required additional info or a response from the author for over 14 days. When you get the chance, please comment with the additional info requested. Otherwise, this issue will be closed in 14 days.

github-actions[bot] commented 4 months ago

This issue has been marked as stale because it has required additional info or a response from the author for over 14 days. When you get the chance, please comment with the additional info requested. Otherwise, this issue will be closed in 14 days.