carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
597 stars 176 forks source link

fix: add calOptions as reactive prop #1585

Closed davidnixon closed 2 months ago

davidnixon commented 2 months ago

Contributes to issue from slack

What did you do?

Tweaked the date picker to make calOptions reactive.

How have you tested it?

Add reactive options to storybook and tested in separate app.

Were docs updated if needed?

davidnixon commented 2 months ago

Via slack

Sinju V S That's worked. ... We moved our code to production with the patch module

davidnixon commented 2 months ago

Left a comment, its only a nuance, other than that, lgtm.

@benceszenassy Thanks! Could you have another look and see if you like the change.