search

carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
597 stars 176 forks source link

fix(storybook): brandUrl point to main root #1586

Closed benceszenassy closed 2 months ago

benceszenassy commented 2 months ago

What did you do?

Updated storybook brandUrl.

Why did you do it?

It still pointed to packages/v3, but v3 is in root now.

How have you tested it?

Build storybook locally, and clicked the brand name

Were docs updated if needed?

benceszenassy commented 2 months ago

hi @davidnixon, if i run yarn lint on the code base, i get 315 files modified, these modifications contains only line endings (crlf -> lf). this is a valid result of the command? (i did not committed these changes)

its requested by

Delete ␍eslintprettier-vue/prettier

davidnixon commented 2 months ago

hi @davidnixon, if i run yarn lint on the code base, i get 315 files modified, these modifications contains only line endings (crlf -> lf). this is a valid result of the command? (i did not committed these changes)

its requested by

Delete ␍eslintprettier-vue/prettier

I see:

yarn lint
 DONE  No lint errors found!

I think is windows: https://eslint.org/docs/latest/rules/linebreak-style#:~:text=The%20linebreaks%20(new%20lines)%20used,n%22%20for%20(CRLF). Maybe setting this flag explicitly fixes this on windows?