search

carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
608 stars 180 forks source link

build: move dev postinstall #1611

Closed davidnixon closed 4 months ago

davidnixon commented 4 months ago

Contributes to #1576

What did you do?

  1. Move the local development postinstall (hooks for husky etc) out of the scripts area of package.json during packaging
  2. Copy the package / prod postinstall (ibm telemetry) from "packrat" area of package.json to "scripts" during packaging

Since the dev postinstall is no longer in scripts there is no way for npm to find and run it. Right? I think npm 10 may be running everything with a "_postinstall" suffix so another alternative would be to rename the "dev_postinstall" to something else. Moving completely out of scripts area seems safer. carbon-vue-3.0.17-8eb61.tgz

Why did you do it?

node 20/npm 10 issues

How have you tested it?

locally with local package tgz package

Were docs updated if needed?

davidnixon commented 4 months ago

@guilherme-gm what do you think?

guilherme-gm commented 4 months ago

wow that was fast :) I think this might work, and I agree with you that having only one script with the postinstall word should be enough, unless npm is somehow copying from the repo (which I think it is unlikely). once you publish a release I can test it

gabisinhas commented 4 months ago

Hello Guys davidnixon, Can we reopen this ticket ?? I am facing the same issue even with the latest update from Carbon Vue 3.0.18 image