search

carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
609 stars 179 forks source link

Data Table V10: differences with the carbon design #321

Closed ZrianinaMariia closed 4 years ago

ZrianinaMariia commented 5 years ago

Detailed description

  1. Checkboxes in the table are not vertically aligned with text.

image

  1. In case of one or more items selected: 'cancel' button should be displayed on the left and number of selected items should be on the right, however I am not sure how strict this rule is.

  2. Carbon design does not show any example of how filter and actions icons should look like (however vue storybook has such examples). This point is more like a question than bug.

  3. Menu meatballs should be visible only on row hover, not always visible.

  4. Columns sorting is missing.

  5. Table with pagination: 'Items per page' text is missing ':'.

  6. Table with pagination: separator and spacing between 'items per page' and 'a-b of X items' differ from carbon design (separator's colour and height).

  7. Table with pagination: dropdown to select page number is missing.

  8. Table with pagination: a part that displays how many pages, differ, i.e. should be 'of X pages' instead of '1 of 0'.

  9. Table with pagination: left/right nav arrows style differs.

  10. Table with pagination: there should be no current page number between nav arrows.

Carbon-vue pagination: image

Carbon design pagination: image

  1. 'Slotted HTML' story has problem with sizes. In addition, 'Rule' columns contain links that lead to the 'Default' folder components and it is a bit confusing.

  2. Expandable data table story is missing.

306

lee-chase commented 5 years ago

With a small number of fixes the latest 10.1 CSS Vue and React implementations look the same.

This appears to be a core CSS issue.

image

lee-chase commented 5 years ago

A number of these issues are related to the current state of @ZrianinaMariia.

See https://github.com/IBM/carbon-components/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+data+table+

lee-chase commented 5 years ago

Expandable functionality should be raised as a separate enhancement request.

lee-chase commented 4 years ago

Closing as all resolved