carbon-design-system / carbon-contribution

Documentation on how to contribute back to Carbon
https://www.carbondesignsystem.com/contributing/designers
7 stars 4 forks source link

Contribution: Noneditable User Interface Elements #17

Closed kaylarakower closed 5 years ago

kaylarakower commented 5 years ago

Name: Noneditable User Interface Elements

Research: Users of the Enterprise CMS have a form that authors edit and approvers review. Approvers should not be able to edit the form, but need to review for errors and return to the editor to revised as needed. I was directed by Tom Dayton to Sun Web Application, 6.8.1 Noneditable User Interface Elements, which describes this exact use case.

Images: https://ibm.box.com/s/172j35uz1f0ulclf4x3l7vl508apenvy

Sketch file: https://ibm.box.com/s/wfjtwupcp4fcazuplwuzbn871ebx1qeh

Contributing team: DrupalOne

Contributing designer: Kayla Rakower, kayla.rakower@ibm.com

Contributing developer: Chris Wilson, ccwilson@us.ibm.com

designertyler commented 5 years ago

Hi @kaylarakower thanks for submitting!

There's a PR open right now to include a read-only state for the text field. Would these specs work for your needs? https://github.com/carbon-design-system/carbon/issues/3018

kaylarakower commented 5 years ago

@designertyler This design was created for a slightly use case as none of the fields would be editable, so there is a different state for the accordion as well which I do not believe is covered in #3018. Added a link to this design to that ticket.

shixiedesign commented 5 years ago

This feels like a larger component – should we add an alternative form variant? @designertyler @aagonzales This layout could be useful in some situations (probably more common in digital/editorial).

If yes, then there has to be different inputs styling.

This is an enhancement category issue though. We will evaluate in more detail next month. Will transfer issue to main carbon repo. Thanks!

shixiedesign commented 5 years ago

Issue moved to carbon-design-system/carbon #3125 via ZenHub