carbon-design-system / carbon-contribution

Documentation on how to contribute back to Carbon
https://www.carbondesignsystem.com/contributing/designers
7 stars 4 forks source link

Contribution: Selectable Tag #33

Open AT-public opened 5 years ago

AT-public commented 5 years ago

Component Name

Selectable Tag

Reason & Research for this change? 

Screen Shots

image

image

Selectable tag

Additional Information

Link to Sketch File WH Components / Patterns / Code are not open source but can provide an Abstract link.

Contributing Designers & Dev

Andrew Thompson (@AT-public) Liz Judd (@elizabethsjudd)

AT-public commented 5 years ago

@designertyler I wanted to follow up & see what additional information you might need for these contributions to make a determination on whether or not these are contributions that Carbon might accept?

designertyler commented 5 years ago

@AT-public This is something we'd like to see as a contribution.

There were questions from the team about the example screenshot where the checkmark is on the left and didn't seem to match the mockups.

This one follows the visual language and other components more closely, but there's no unselected state mocked up with it. image

AT-public commented 5 years ago

@designertyler great we will start working on this contribution.