search

carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).
Apache License 2.0
1.07k stars 153 forks source link

[modal] resize height / overrides bug #398

Closed kylearichard closed 11 months ago

kylearichard commented 3 years ago

Detailed description

In the latest version of the Sketch kit, the modal components don't honor the height that is set by the designer when any one of the overrides are edited. This bug is present on all 4 theme kits, in all modal widths. See below:

ezgif com-gif-maker (2)

My expectation is that the height value would be persisted (or, if needed, would bump out to accommodate additional lines of text) whenever overrides are changed. The bug adds a bit of extra design time, as I need to re-input the height for the modal component on any instance where the overrides need to change.

Steps to reproduce the issue

  1. Configure the overrides for title, description, and button labels on a modal component
  2. Resize the height of the modal
  3. Edit one of the overrides

The height will snap back to the default value from when it was dropped onto the artboard.

stale[bot] commented 3 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 3 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 3 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 3 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 2 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

aagonzales commented 11 months ago

Sketch is no longer a priority design tool for IBM and we are closing all feature updates as not planned.