carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).
Apache License 2.0
1.07k stars 154 forks source link

[Figma]: add brand logos to Third party logo library #547

Open laurenmrice opened 2 years ago

laurenmrice commented 2 years ago

Add branded logos to Third party logo library

Screen Shot 2022-07-14 at 12 39 50 PM

To do

sethibm commented 2 years ago

@laurenmrice Thanks for creating this! I see the Gatsby theme has the app icons available now and tested it today with my Figma component. It's possible to swap instances no problem and works well, looks good.

So I think as soon as the same app icons are published in the IBM Design Language Icon library, we can update component to reference those icons and swap in and out from there. Looking forward to it...

sethibm commented 2 years ago

@laurenmrice One note on restriction to 32px for this implementation in library. I think for my use case, related to guidance with text + icons together, 32px only will require me to make text too large.

For Figma component where I will use these app icons, it currently has icon reduced to 20px size to work with 16pt text. If the library only provides 32px version, I would only be able to use 24pt Plex with the 32px icon, per guidance, and that would be too large for this text link, which is best at 16pt.

For placement in library, is it possible to allow for 20px and 32px with icon sizes, or do you have suggestions?

Fyi, this is for an internal Figma template component that will not be public facing, rather just for IBM.com web page design + production.

Here is a quick view of the component in raw form, then populated version. And one larger screenshot showing it in context.

Screen Shot 2022-07-18 at 12 32 01 PM Screen Shot 2022-07-18 at 12 33 05 PM Screen Shot 2022-07-18 at 12 32 50 PM
laurenmrice commented 2 years ago

Hey @sethibm, I spoke with Andreea Vintila who created the Gatsby theme library, we do use these branded logos as 32px in resource cards, and as 20px in mini resource cards, so those two sizes are fine. We will add some written guidance around this in Figma around sizing.

sethibm commented 2 years ago

Thanks @laurenmrice, good to hear and looking forward...

stale[bot] commented 2 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

sethibm commented 1 year ago

@laurenmrice I wonder if this change was made to the IBM Design Language Icon library yet? We beta launched the Figma library for annotating IBM.com pages but the component still uses Gatsby Library icons. I'd like to switch it to the more commonly enabled library if these icons are available. I just checked and don't see it in my version of that Figma library.

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

laurenmrice commented 11 months ago

After some discussion we are going to add these to a Third party logo library which is already in progress in Figma. There are multiple libraries currently being created to house different types of icons based on their usage. For example: App icons will have its own library, UI icons has its own library, and Third party icons will have its own library.

mjabbink commented 3 weeks ago

@laurenmrice The Adobe icon should be updated. For Adobe Fonts, it’s in the below Figma file. https://www.figma.com/design/A8Aqo87GXAFPJ7gbIvJYkL/%5BIDL%5D-Typeface-%26-What's-new?node-id=910-4234&t=qhzJCDuZWJxCZISf-0

For the Adobe logo icon itself is here: https://www.adobe.com/legal/permissions/icons-web-logos.html

Adobe Fonts

Screenshot 2024-08-28 at 9 40 39 AM

Adobe and Acrobat media_1d87bf78b1ce19defbef0c7858b4df696215a4048 media_198085e02894bf8d3f7db0b517d4b2833d35d5587-2