[Data table] Batch action bar needs custom disabled state

carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).

Apache License 2.0

1.07k stars 154 forks source link

[Data table] Batch action bar needs custom disabled state #665

Open aagonzales opened 1 year ago

aagonzales commented 1 year ago

Disabled button

The primary button disabled state is also incorrect in Figma. It has a custom disabled state in code.

Should follow the spec here

Button padding

This looks like its been fixed with the addition of a resizer prop._

~Currently, in Figma the batch action bar is using the primary buttons with the 64px padding on the right. However, they should be using a custom (maybe?) button with 16px padding left and right (see storybook)~

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

thyhmdo commented 9 months ago

Possible solution:

We probably need to detach these current buttons and create customized buttons for batch action buttons. They're linked to the core Buttons so they will inherit elements of their variants.
We'll need to confirm what states these button can have but it looks like we have Enabled, Hover, Focus, and Disabled states?
This may also avoid the confusion if users can have other type of button variants or states for these batch actions