Closed AmandaFurukawa closed 1 year ago
I see that 8px is the proper spacing between the label and field so text input is the one that is incorrect (its 4) - but also the way the spacing is set up for all components are not consistent (FYI)
Here's how the spacing should work in Figma, the 4px problem was coming from the helper text spec. I also see the spacing set-up inconsistency that she mentioned.
Ok I have updated the text input
labels to have the total 8px bottom padding and the fix will be available in the next library publish.
However, concerning the other problem with inconsistent spacing here is what I found out. There are two ways of doing label spacing
This one matches the spec better and how it is done in code.
White theme
Only making updates in the white theme due to future theme consolidation work.
Detailed description
In the figma library - carbon V11
There is inconsistent spacing set between the label and field components (dropdown, input, number input, text area input). It looks like some of the labels have extra padding set which is causing the spacing to be more than it should be.
Steps to reproduce the issue
Additional information
the label margin of number input, dropdown have below padding set to 4 (text input is set to no extra padding)
text area has 8 spacing for the label/text area (which i guess is overriding the text area overall 4px spacing)
Add labels
Please choose the appropriate label(s) from our existing label list to ensure that your issue is properly categorized (i.e.use the
libraries
label for any issue relating to the Carbon Sketch Library). This will help us to better understand and address your issue.