search

carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).
Apache License 2.0
1.07k stars 153 forks source link

Text + Icon buttons alignment broken #708

Closed swwebster closed 1 year ago

swwebster commented 1 year ago

Icon + Text buttons alignment broken

The icon no longer aligns correctly.

image

Detailed description

What version of the Carbon Design System Kit are you using? v10 Figma Libraries

Is this issue related to a specific component? If so please give the page, artboard, and layer/symbol name. All text + icon buttons variants

What did you expect to happen? What happened instead? What would you like to see changed? The icon should align to the right of the text.

Is this issue being filed based on a discrepancy between the website/code and the kit? If so what is the inconsistency? No

What offering/product do you work on? Any pressing ship or release dates we should be aware of? IBM Storage Fusion (we are working on moving to v11 but not there yet)

Steps to reproduce the issue

  1. Place a new button component
  2. Swap to a text + icon variant
  3. Icon is placed on the left, not the right

Add labels

Please choose the appropriate label(s) from our existing label list to ensure that your issue is properly categorized (i.e.use the libraries label for any issue relating to the Carbon Sketch Library). This will help us to better understand and address your issue.

swwebster commented 1 year ago

If I detach the instance, it aligns correctly...

laurenmrice commented 1 year ago

Fixed in

laurenmrice commented 1 year ago

@swwebster This should be fixed now and published.