[Contextual layers] finish attaching contextual layer styles to components

carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).

Apache License 2.0

1.07k stars 153 forks source link

[Contextual layers] finish attaching contextual layer styles to components #758

Open laurenmrice opened 9 months ago

laurenmrice commented 9 months ago

Acceptance criteria

Finish attaching the contextual layer styles to components that should use them.

Components

[ ] Code snippet
[ ] Contained list
[ ] Data table
[ ] Date picker
[ ] Dropdown / Combobox / Multiselect
[ ] File uploader
[ ] Menu
[ ] Menu button
[ ] Pagination
[ ] Popover
[ ] Structured list
[ ] Tabs (contained)
[ ] Tile
[ ] Treeview

Review

[ ] Carbon review
[ ] Figma review

kingtraceyj commented 8 months ago

Variable styles have been added in a branch

Open questions

Does using contextual layers in Figma make sense for all components? ie. code snippet?
Should we have a hybrid approach? Some components using a contextual layer token while other using the standard layering model (-01, -02, -03)
Is there another solution? (would it cause issues if we added a background token to the main figma file? or we could separate background tokens from layering—the current model has them together)

kingtraceyj commented 8 months ago

We are going to need to do more research on the best way to implement contextual tokens. the scope is bigger than first anticipated. so far, it's a little buggy and not production ready.

sstrubberg commented 8 months ago

We need @juanencalada's input here.