[Password input] Password input - Add the password visibility

carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).

Apache License 2.0

1.06k stars 154 forks source link

[Password input] Password input - Add the password visibility #807

Closed thyhmdo closed 3 weeks ago

thyhmdo commented 1 month ago

Problem

Missing the password visibility toggle

Reference

Storybook link example: https://react.carbondesignsystem.com/?path=/story/components-textinput--toggle-password-visibility

Tasks

[x] Fluid styles
[x] Add the "eye" icon + dot symbol when turning this prop on

Review

[x] Carbon
[x] Figma

laurenmrice commented 1 month ago

@thyhmdo We do have the default style under Password input in Figma, but we don't have the fluid style. Juan may have more context as to why it was split into its own component page.