search

carbon-design-system / carbon-design-kit

A versioned, comprehensive kit of the Carbon Design System visual assets (components, icons, pictograms, text styles, color styles, grid templates).
Apache License 2.0
1.06k stars 154 forks source link

[Dropdown] Multi-select: Minor bugs related to the background color & label text #837

Open Kritvi-bhatia17 opened 3 weeks ago

Kritvi-bhatia17 commented 3 weeks ago

Detailed description

  1. The background color for the multi-select dropdown when it's in focus state and the menu is open differs for the medium-sized dropdown. This color token needs to be changed to "field-01"
    image

    Solution: The background color is already set to field-01, but we need to remove the focus border background color (D9D9D9) as shown in the image.

  1. Prompt text and selected text can also be updated for filterable multi-select
    image

Note: This might require a review of the placeholder values for all variants of dropdowns.

benjamin-kurien commented 3 weeks ago

Thanks @Kritvi-bhatia17 for opening this issue.

  1. The prompt text needs to be updated to "Choose options" - for both default and fluid variants
  2. The bg color on the field needs to be updated to "field-01"
benjamin-kurien commented 3 weeks ago

Prompt text and selected text can also be changed for filterable multiselect

Kritvi-bhatia17 commented 3 weeks ago

Thanks @Kritvi-bhatia17 for opening this issue.

  1. The prompt text needs to be updated to "Choose options" - for both default and fluid variants
  2. The bg color on the field needs to be updated to "field-01"

Hi @benjamin-kurien

  1. For the second issue, the background color is already set to field-01, but we need to remove the focus border background color (D9D9D9) as shown in the image. image

I will update the issue with the solution.