Investigate whether dynamic imports are still needed

IgnacioBecerra commented 2 years ago

Summary

A few months ago we had to start using dynamic imports in order for the components get rendered, or else the server would error out with this message:

Not sure if this is still needed in our pages since we're able to use some regular imports properly, so we might need to investigate if it is so.

How it's currently being done:

const DDSCardCTAFooter = dynamic(
  import(
    "@carbon/ibmdotcom-web-components/es/components-react/cta/card-cta-footer"
  ),
  { ssr: true }
);

How it should be (hopefully):

import DDSCardCTAFooter from '@carbon/ibmdotcom-web-components/es/components-react/cta/card-cta-footer';

jeffchew commented 2 years ago

@IgnacioBecerra is there a priority for this?

IgnacioBecerra commented 2 years ago

@jeffchew Everything is working properly at the moment with the dynamic imports so far, so this isn't critical

stale[bot] commented 1 year ago

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 1 year ago

As there's been no activity since this issue was marked as stale, we are auto-closing it.

carbon-design-system / carbon-for-ibm-dotcom-nextjs-test

Investigate whether dynamic imports are still needed #204

Summary