carbon-design-system / carbon-for-ibm-dotcom-website

This is the Carbon for IBM.com website, which includes documentation and guidelines around design and development for IBM.com
https://www.ibm.com/standards/carbon/
Apache License 2.0
40 stars 42 forks source link

feat(expressive modal): v1 & v2 guidance updates #1731

Closed sangeethababu9223 closed 11 months ago

sangeethababu9223 commented 11 months ago

Related Ticket(s)

https://github.com/carbon-design-system/carbon-for-ibm-dotcom-website/issues/1616

Description

v1 & v2 guidance updates

Changelog

New

Changed

Removed

ibmdotcom-bot commented 11 months ago

Deploy preview created: https://ibmdotcom-library.s3-web.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/1731/index.html

Built with commit: 6890c487b92d08999a0e211b678d1d28c964e549

sangeethababu9223 commented 11 months ago

@ariellalgilmore , Added images to the behaviour section.

oliviaflory commented 11 months ago

@sangeethababu9223 could you please look into adding the GIF player to your two GIFs? I think the light prop might be best but if you could try light for the first and dark for the second so we can see both that would be helpful.

We could take a static pull from your video files for the static image?

sangeethababu9223 commented 11 months ago

@oliviaflory, Added Gif player as per your comment. Please check.

oliviaflory commented 11 months ago

It's perfect, thanks you @sangeethababu9223 !