search

carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
271 stars 156 forks source link

[`@carbon/ibmdotcom-styles`]: remove React classes from component styles #11194

Open kennylam opened 12 months ago

kennylam commented 12 months ago

Currently all component stylesheets still have a large amount of React-specific styles. These need to be removed. Items in the tasklist should be converted to issues as they are assigned. Net-new components created as web components have been excluded.

### Components
- [ ] https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/11198
- [ ] https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/11219
- [ ] callout quote
- [ ] callout with media
- [ ] card group
- [ ] card section simple
- [ ] card
- [ ] content block cards
- [ ] content block horizontal
- [ ] content block media
- [ ] content block mixed
- [ ] content block segmented
- [ ] content block simple
- [ ] content group cards
- [ ] content group pictograms
- [ ] content group simple
- [ ] content group
- [ ] content item row
- [ ] content item
- [ ] content section
- [ ] cta block
- [ ] cta section
- [ ] cta
- [ ] dotcom shell
- [ ] expressive modal
- [ ] feature card
- [ ] footer
- [ ] global banner
- [ ] horizontal rule
- [ ] image
- [ ] in page banner
- [ ] leadspace
- [ ] leadspace block
- [ ] lightbox media viewer
- [ ] link list
- [ ] link list section
- [ ] link with icon
- [ ] locale modal
- [ ] logo grid
- [ ] https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/11263
- [ ] notice choice
- [ ] quote
- [ ] scroll animations
- [ ] table of contents
m4olivei commented 11 months ago

Hey @sangeethababu9223 👋 . I see you've opened a PR, is your intent to cover off all of the components in the list there? My impression per the issue description here was that there would be a PR per component, and each component in the list assigned individually. I have space to take on a few components, but I don't want to duplicate work. Let us know how we can work in tandem. Thanks!

sangeethababu9223 commented 11 months ago

Hi @m4olivei, I had created the PR with the intent to include changes to all the components in the PR itself. I'm afraid I am almost done with all of them - some of the components didn't need any change in the style so I've left those as it was.

Thanks for pointing out the need for separate PRs, I'd check on that make the necessary changes. Thanks Again!

sangeethababu9223 commented 11 months ago

@m4olivei , As we discussed, I've created an issue for masthead. You or @jkaeser could look into it. Thanks