carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
264 stars 157 forks source link

Develop initial Footer component version #255

Closed jeffchew closed 4 years ago

jeffchew commented 4 years ago

hahnrob created the following on Jun 20:

As a developer, I need to create the Footer component within the Dotcom components package so that adopters can utilize this component in their application

Additional information

Acceptance criteria

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1080

jeffchew commented 4 years ago

On Jul 26, Wonil-Suh1 commented: Please use the links from the current site — the same order and label and URL.

jeffchew commented 4 years ago

On Jul 29, james-dow commented: Submitted a pull request that basically initializes a basic structure for the Footer, so we can start building it out.

https://github.com/carbon-design-system/ibm-dotcom-library/pull/30

jeffchew commented 4 years ago

On Jul 29, james-dow commented: As I worked on the above initial pull request I realized we maybe blocked by https://github.com/carbon-design-system/ibm-dotcom-library/issues/255. I'm in discussion with @Jeff-Chew and @Kenny-Lam to confirm or not, and figure out how to unblock it if we are.

jeffchew commented 4 years ago

On Aug 01, james-dow commented: A number of changes came to the footer yesterday from @Wonil-Suh1.

image

image

jeffchew commented 4 years ago

On Aug 02, Wonil-Suh1 commented: Updated footer specs.

Full version

dot-com-footer--specs--max

dot-com-footer--specs--xlg

dot-com-footer--specs--lg

dot-com-footer--specs--md

dot-com-footer--specs--md-max

dot-com-footer--specs--sm

dot-com-footer--specs--sm-max

Minimal version

dot-com-footer-minimal--specs--max

dot-com-footer-minimal--specs--xlg

dot-com-footer-minimal--specs--lg

dot-com-footer-minimal--specs--md

dot-com-footer-minimal--specs--sm

jeffchew commented 4 years ago

On Aug 02, Wonil-Suh1 commented: And the sketch file is here.

jeffchew commented 4 years ago

On Aug 07, Wonil-Suh1 commented: @james-dow please use these specs for links:

color: $text-02 (gray-30, #bebebe)
hover color: $text-01 (gray-10, #f3f3f3)
active color: $text-04 (white, #ffffff)
jeffchew commented 4 years ago

On Aug 07, Wonil-Suh1 commented: Updated specs:

Full version

dot-com-footer--specs--max

dot-com-footer--specs--xlg

dot-com-footer--specs--lg

dot-com-footer--specs--md-max

dot-com-footer--specs--md

Short version

dot-com-footer-minimal--specs--max

dot-com-footer-minimal--specs--xlg

dot-com-footer-minimal--specs--lg

dot-com-footer-minimal--specs--md

dot-com-footer-minimal--specs--sm

jeffchew commented 4 years ago

On Aug 08, james-dow commented: @Wonil-Suh1: @hahnrob created a new issue for this ticket. https://github.com/carbon-design-system/ibm-dotcom-library/issues/255

jeffchew commented 4 years ago

On Aug 08, Wonil-Suh1 commented: @james-dow interactive state specs:

dot-com-footer--interactive-specs--links dot-com-footer--interactive-specs--locale-selector dot-com-footer--interactive-specs--logo