carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
264 stars 157 forks source link

Add Carbon Marketing Theme #285

Closed jeffchew closed 4 years ago

jeffchew commented 4 years ago

hahnrob created the following on Jul 17:

User Story

As a [user role below]: IBM.com Library Adopter

I need to: apply an expressive theme over Carbon components used in my application

so that I can: provide a non-productive themed version of my application using Carbon

Additional information

Acceptance criteria

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1248

jeffchew commented 4 years ago

On Aug 12, Jeff-Chew commented: Based on timing it looks like this won't be ready for development in Sprint 16. Some documentation on the October release for Carbon:

https://github.com/carbon-design-system/carbon/wiki/Carbon-October-Release-Draft-Notes https://github.com/carbon-design-system/carbon/wiki/Carbon-Release-Schedule---2019

We may be able to start this if an early version (release candidate) is available, need to discuss with Carbon team on timing.

cc: @linda-carotenuto @hahnrob @Wonil-Suh1

jeffchew commented 4 years ago

@photodow can you provide any additional details around this story?

cc: @RobertaJHahn

photodow commented 4 years ago

@jeffchew is there anything specific you'd like to know?

The latest news is this work is delayed due to Carbon still working on the solution on their end. Matt reached out earlier last week to @jeffchew and I to let us know they might be able to pull us in allowing us to help them implement Carbon's part as early as this week (as of writing this I haven't looped back around on this).

Here is a link to their project board: https://github.com/orgs/carbon-design-system/projects/33

Here is a quick example Josh put together to demonstrate their solution. https://www.sassmeister.com/gist/a98e19c89210d91cdc2b6b923082b8a3

Basically:

RobertaJHahn commented 4 years ago

@photodow did you loop back with Carbon? Could you provide the latest status in this issue?

cc: @ljcarot

jeffchew commented 4 years ago

@RobertaJHahn moving this to sprint 22 after catching up with @wonilsuhibm on a recent design meeting with Carbon yesterday. cc: @oliviaflory @photodow

jeffchew commented 4 years ago

Added dependency to #712 after various discussions, will need to approach the foundation story first before assessing the next steps for this story.

jeffchew commented 4 years ago

@RobertaJHahn @ljcarot @wonilsuhibm I think this story can be closed since we have already moved forward with the proxy approach, right?

ljcarot commented 4 years ago

@jeffchew yes, we've changed direction and instead of 'adding Carbon Marketing Theme', we're building the theme through our proxy approach.

RobertaJHahn commented 4 years ago

Closing this issue as the implementation direction has changed.