carbon-design-system / carbon-for-ibm-dotcom

Carbon for IBM.com is based on the Carbon Design System for IBM
https://www.ibm.com/standards/carbon/
Apache License 2.0
262 stars 156 forks source link

Pattern: CTA section: Buttons #3016

Closed ltitle closed 4 years ago

ltitle commented 4 years ago

CTA section: Buttons

Describe in detail the issue you're having.

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

CTA Section Pattern (default version)

What did you expect to happen? What happened instead? What would you like to see changed?

As seen in Storybook: Space between buttons is 16px

image

As expected from visual specs: Space between buttons is 32px

image


As seen in Storybook: Buttons are stacking at Small and Medium breakpoints

image

As expected in visual specs: Buttons should only stack on Small breakpoint

image

image


As seen in Storybook: Buttons are not full width on Small breakpoint

image

As expected in visual specs: Buttons should be full width on Small breakpoint

image

What browser are you working in?

Chrome

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IBM.com Reboot

Steps to reproduce the issue

https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/2992/index.html?path=/story/patterns-sections-ctasection--default

RobertaJHahn commented 4 years ago

This is still not working on newer models for both iPhone and Android phones with width greater than 320px. Reopening this issue.

ariellalgilmore commented 4 years ago

@RobertaJHahn can we close this issue again? Talked to the team and it is currently inline with the design specs

RobertaJHahn commented 4 years ago

@ariellalgilmore OK, closing.